lkml.org 
[lkml]   [2011]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRE: [PATCH v3 1/2] PRUSS UIO driver support

> -----Original Message-----
> From: Thomas Gleixner [mailto:tglx@linutronix.de]
> Sent: Thursday, February 24, 2011 2:24 AM
> To: Sergei Shtylyov
> Cc: TK, Pratheesh Gangadhar; davinci-linux-open-
> source@linux.davincidsp.com; Chatterjee, Amit; gregkh@suse.de; linux-
> kernel@vger.kernel.org; hjk@hansjkoch.de; linux-arm-
> kernel@lists.infradead.org
> Subject: Re: [PATCH v3 1/2] PRUSS UIO driver support
>
> On Wed, 23 Feb 2011, Sergei Shtylyov wrote:
> > Hello.
> >
> > On 23-02-2011 23:25, Thomas Gleixner wrote:
> >
> > > > + prussio_virt_addr =
> > > > + ioremap(regs_prussio->start,
> > > > + regs_prussio->end - regs_prussio->start + 1);
> >
> > > Either make those variable names shorter or do:
> >
> > > len = regs_prussio->end - regs_prussio->start + 1;
> >
> > Or even:
> >
> > len = resource_size(regs_prussio);
> >
> > > prussio_virt_addr = ioremap(regs_prussio->start, len);
>
> Good point. Forgot about that one :)
>
Thanks will do this.

Pratheesh


\
 
 \ /
  Last update: 2011-02-24 14:59    [W:0.089 / U:0.216 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site