Messages in this thread | | | From | "TK, Pratheesh Gangadhar" <> | Date | Thu, 24 Feb 2011 19:25:51 +0530 | Subject | RE: [PATCH v3 1/2] PRUSS UIO driver support |
| |
> -----Original Message----- > From: Thomas Gleixner [mailto:tglx@linutronix.de] > Sent: Thursday, February 24, 2011 2:24 AM > To: Sergei Shtylyov > Cc: TK, Pratheesh Gangadhar; davinci-linux-open- > source@linux.davincidsp.com; Chatterjee, Amit; gregkh@suse.de; linux- > kernel@vger.kernel.org; hjk@hansjkoch.de; linux-arm- > kernel@lists.infradead.org > Subject: Re: [PATCH v3 1/2] PRUSS UIO driver support > > On Wed, 23 Feb 2011, Sergei Shtylyov wrote: > > Hello. > > > > On 23-02-2011 23:25, Thomas Gleixner wrote: > > > > > > + prussio_virt_addr = > > > > + ioremap(regs_prussio->start, > > > > + regs_prussio->end - regs_prussio->start + 1); > > > > > Either make those variable names shorter or do: > > > > > len = regs_prussio->end - regs_prussio->start + 1; > > > > Or even: > > > > len = resource_size(regs_prussio); > > > > > prussio_virt_addr = ioremap(regs_prussio->start, len); > > Good point. Forgot about that one :) > Thanks will do this.
Pratheesh
| |