Messages in this thread | | | Date | Wed, 23 Feb 2011 08:43:48 +0000 | From | Jack Stone <> | Subject | Re: [PATCH 3/6] cciss: Mask off error bits of c->busaddr in cmd_special_free when calling pci_free_consistent |
| |
On 22/02/2011 20:14, Stephen M. Cameron wrote: > From: Stephen M. Cameron <scameron@beardog.cce.hp.com> > > Signed-off-by: Stephen M. Cameron <scameron@beardog.cce.hp.com> > --- > drivers/block/cciss.c | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c > index 2e832b0..03cead6 100644 > --- a/drivers/block/cciss.c > +++ b/drivers/block/cciss.c > @@ -193,7 +193,7 @@ static int __devinit cciss_find_cfg_addrs(struct pci_dev *pdev, > u64 *cfg_offset); > static int __devinit cciss_pci_find_memory_BAR(struct pci_dev *pdev, > unsigned long *memory_bar); > - > +static inline u32 cciss_tag_discard_error_bits(ctlr_info_t *h, u32 tag);
Is there any reason we cannot just reorder the functions rather than have this forward declaration?
Thanks,
Jack
| |