Messages in this thread Patch in this message | ![/](/images/icornerl.gif) | | Date | Thu, 24 Feb 2011 05:18:51 +0100 | From | Andrea Arcangeli <> | Subject | Re: [PATCH 8/8] Add VM counters for transparent hugepages |
| |
Incremental fix for your patch 8 (I doubt it was intentional).
=== Subject: thp: move THP_SPLIT from __split_huge_page_pmd to inner split_huge_page
From: Andrea Arcangeli <aarcange@redhat.com>
Provide more accurate stats by accounting every split_huge_page not only the ones coming from pmd manipulations.
Signed-off-by: Andrea Arcangeli <aarcange@redhat.com> --- mm/huge_memory.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
--- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -1393,6 +1393,7 @@ int split_huge_page(struct page *page) BUG_ON(!PageSwapBacked(page)); __split_huge_page(page, anon_vma); + count_vm_event(THP_SPLIT); BUG_ON(PageCompound(page)); out_unlock: @@ -2287,9 +2288,6 @@ void __split_huge_page_pmd(struct mm_str spin_unlock(&mm->page_table_lock); return; } - - count_vm_event(THP_SPLIT); - page = pmd_page(*pmd); VM_BUG_ON(!page_count(page)); get_page(page);
| ![\](/images/icornerr.gif) |