Messages in this thread Patch in this message | | | Date | Tue, 22 Feb 2011 21:20:42 -0800 | From | Dmitry Torokhov <> | Subject | Re: Boot time regression in 2.6.38 after initial wq merge |
| |
On Tue, Feb 22, 2011 at 09:14:46PM +0100, pantherchen@versanet.de wrote: > On 02/22/2011 08:52 PM, Dmitry Torokhov wrote: > >Ewww... tty/ldisc... > > > >Does it help if you change drivers/input/serio/serio.c::serio_queue_event() > >from calling > > > > schedule_work(&serio_event_work); > > > >to call > > > > queue_work(system_long_wq,&serio_event_work); > > > >? > > Yes, that works: http://img.xrmb2.net/images/499337.png >
Great!
OK, so below is properly formatted patch. I am going to send it upstream unless somebody objects.
Thanks.
-- Dmitry
Input: serio/gameport - use 'long' system workqueue
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Commit 8ee294cd9def0004887da7f44b80563493b0a097 converted serio subsystem event handling from using a dedicated thread to using common workqueue. Unfortunately, this regressed our boot times, due to the fact that serio jobs take long time to execute. While the new concurrency managed workqueue code manages long-playing works just fine and schedules additional workers as needed, such works wreck havoc among remaining users of flush_scheduled_work().
To solve this problem let's move serio/gameport works from system_wq to system_long_wq which nobody tries to flush.
Reported-and-tested-by: Hernando Torque <pantherchen@versanet.de> Signed-off-by: Dmitry Torokhov <dtor@mail.ru> ---
drivers/input/gameport/gameport.c | 2 +- drivers/input/serio/serio.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/input/gameport/gameport.c b/drivers/input/gameport/gameport.c index 23cf8fc..5b8f59d 100644 --- a/drivers/input/gameport/gameport.c +++ b/drivers/input/gameport/gameport.c @@ -360,7 +360,7 @@ static int gameport_queue_event(void *object, struct module *owner, event->owner = owner; list_add_tail(&event->node, &gameport_event_list); - schedule_work(&gameport_event_work); + queue_work(system_long_wq, &gameport_event_work); out: spin_unlock_irqrestore(&gameport_event_lock, flags); diff --git a/drivers/input/serio/serio.c b/drivers/input/serio/serio.c index 7c38d1f..ba70058 100644 --- a/drivers/input/serio/serio.c +++ b/drivers/input/serio/serio.c @@ -299,7 +299,7 @@ static int serio_queue_event(void *object, struct module *owner, event->owner = owner; list_add_tail(&event->node, &serio_event_list); - schedule_work(&serio_event_work); + queue_work(system_long_wq, &serio_event_work); out: spin_unlock_irqrestore(&serio_event_lock, flags);
| |