Messages in this thread | | | Subject | Re: [PATCH] rt2x00: Use ops name instead of device name | From | Steven Rostedt <> | Date | Tue, 22 Feb 2011 14:52:38 -0500 |
| |
On Tue, 2011-02-22 at 20:33 +0100, Ivo Van Doorn wrote: > Hi, > > On Tue, Feb 22, 2011 at 2:44 PM, Steven Rostedt <rostedt@goodmis.org> wrote: > > On Tue, 2011-02-22 at 13:34 +0000, Ben Hutchings wrote: > > > >> > 19: 73474106 0 IO-APIC-fasteoi ata_piix, uhci_hcd:usb6, 0000:05:01.0 > > > >> > rt2x00dev->irq = pci_dev->irq; > >> > - rt2x00dev->name = pci_name(pci_dev); > >> > + rt2x00dev->name = ops->name; > > > > > >> But then how can users distinguish the IRQs for multiple devices handled > >> by the same driver? (Probably unusual for WLAN devices, but still > >> possible.) > >> > >> I assume you can't use a net device name as there may be multiple net > >> devices per bus device? > > > > Honestly, I do not know this code well enough, but this patch seemed to > > solve the problem at hand. Hence I sent it out to the experts hoping > > they either take this patch or come up with a proper solution ;) > > > > In any case, just posting the pci address is not a pretty answer. > > I just checked the other wireless drivers, and they all seem to use > the modulename. So I guess your patch is correct. You can add my: > > Acked-by: Ivo van Doorn <IvDoorn@gmail.com>
Thanks!
Actually, to answer Ben's question. lspci should give you what you want.
On my local box (not the one mentioned above):
$ lspci -vv [...] 00:0a.0 Bridge: nVidia Corporation CK804 Ethernet Controller (rev a3) Subsystem: Tyan Computer Tomcat K8E (S2865) Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx- Status: Cap+ 66MHz+ UDF- FastB2B+ ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx+ Latency: 0 (250ns min, 5000ns max)
Interrupt: pin A routed to IRQ 23
Region 0: Memory at febf9000 (32-bit, non-prefetchable) [size=4K] Region 1: I/O ports at b400 [size=8] Capabilities: <access denied> Kernel driver in use: forcedeth
(spaces added by me)
$ cat /proc/interrupts [...] 23: 547 648564 IO-APIC-fasteoi ohci_hcd:usb2, eth0
-- Steve
| |