Messages in this thread | | | From | Bjorn Helgaas <> | Subject | Re: [PATCH 2/6] x86: Minimize initial e820 messages | Date | Tue, 22 Feb 2011 11:43:10 -0700 |
| |
On Friday, February 18, 2011 07:47:07 pm Mike Travis wrote: > Minimize the early e820 messages by printing less characters > for the address range as well as abbreviating the type info > for each entry.
> + pr_info("%s: %Lx+%Lx (%s)\n", who, > + (unsigned long long) e820.map[i].addr, > + (unsigned long long) e820.map[i].size, > + e820_types(e820.map[i].type));
If we're going to change the way we print E820 ranges, I think we should make them consistent with the way we handle %pR, e.g., use something like this:
"%s: [mem %#018Lx-%#018Lx]"
This is a little different because %pR wouldn't make the field so wide, but when we discussed this earlier, keeping the table alignment was thought to be important. That discussion starts here: https://lkml.org/lkml/2010/9/22/248
Same comment applies to the update, remove, PCI gap (which your patch currently doesn't touch), and EFI output.
I know this kind of derails the whole "remove characters" point of your patch (and I support that in principle), but I do think consistency is important, too. We have too many different ways of printing the same information.
Bjorn
| |