lkml.org 
[lkml]   [2011]   [Feb]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCHv2 06/11] unicore32 core architecture: mm related: generic codes
Date
On Tuesday 22 February 2011, Guan Xuetao wrote:
> > > +#ifdef __io
> > > +void __iomem *ioport_map(unsigned long port, unsigned int nr)
> > > +{
> > > + /* we map PC lagcy 64K IO port to PCI IO space 0x80030000 */
> > > + return (void __iomem *) (unsigned long)
> > > + io_p2v((port & 0xffff) + PKUNITY_PCILIO_BASE);
> > > +}
> >
> > Interestingly, this function looks completely correct, but I don't see
> > the definition for __io, so I suspect that the function is not actually
> > getting used.
> When I want to use pci device driver, I will define __io and use ioport_map for drivers.
> It is obviously a trick.

Ok, I see.

> And with your patch for asm-generic/io.h, these codes could be removed.

You'd still need to define ioport_map, but the definition could simply
become

static inline void __iomem *ioport_map(unsigned long port, unsigned int nr)
{
return PCIO_BASE + port;
}

ARnd


\
 
 \ /
  Last update: 2011-02-22 16:21    [W:0.054 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site