lkml.org 
[lkml]   [2011]   [Feb]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] gpio: Fix wrong pointer type in pca953x
On Tue, Feb 22, 2011 at 09:56:50AM +0100, Dirk Eibach wrote:
> struct pca953x_platform_data *pdata;
> struct device_node *node;
> - const uint16_t *val;
> + const u32 *val;
>

This should probably be signed? We compare it against zero later on.

if (*val < 0)
dev_warn(&client->dev,
"invalid gpio-base in device tree\n");

regards,
dan carpenter


\
 
 \ /
  Last update: 2011-02-22 13:43    [W:0.075 / U:0.796 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site