Messages in this thread | | | Date | Tue, 22 Feb 2011 09:30:22 +0900 | From | Naoya Horiguchi <> | Subject | Re: [PATCH] hugetlbfs: correct handling of negative input to /proc/sys/vm/nr_hugepages |
| |
On Mon, Feb 21, 2011 at 04:47:49PM +0100, Petr Holasek wrote: > When user insert negative value into /proc/sys/vm/nr_hugepages it will result > in the setting a random number of HugePages in system (can be easily showed > at /proc/meminfo output). This patch fixes the wrong behavior so that the > negative input will result in nr_hugepages value unchanged. > > Signed-off-by: Petr Holasek <pholasek@redhat.com> > --- > mm/hugetlb.c | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index bb0b7c1..f99d7a8 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -1872,8 +1872,7 @@ static int hugetlb_sysctl_handler_common(bool obey_mempolicy, > unsigned long tmp; > int ret; > > - if (!write) > - tmp = h->max_huge_pages; > + tmp = h->max_huge_pages;
Looks reasonable. hugetlb_overcommit_handler() has the same wrong behavior. So how about fixing that too?
Anyway, Reviewed-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
| |