lkml.org 
[lkml]   [2011]   [Feb]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging/et131x: fix et131x_rx_dma_disable halt_status usage
On Sun, 20 Feb 2011 20:03:34 +0100
Marcin Slusarz <marcin.slusarz@gmail.com> wrote:

> Commit 1bd751c1abc1029e8a0ae63ef4f19357c735a2a3
> ("Staging: et131x: Clean up rxdma_csr") changed csr from bitfield to
> u32, but failed to convert 2 uses of halt_status bit. It did:
>
> - if (csr.bits.halt_status != 1)
> + if ((csr & 0x00020000) != 1)
>
> which is wrong, because second version is always true.
> Fix it.
>
> This bug was found by coccinelle (http://coccinelle.lip6.fr/).
>
> Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
> Cc: Alan Cox <alan@linux.intel.com>
> Cc: Greg Kroah-Hartman <gregkh@suse.de>

Acked-by: Alan Cox <alan@linux.intel.com>


\
 
 \ /
  Last update: 2011-02-20 20:13    [W:0.032 / U:0.280 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site