Messages in this thread | | | Date | Tue, 15 Feb 2011 11:25:50 +0100 | From | Michal Hocko <> | Subject | Re: [PATCH] virtio: use __GFP_NOWARN for try_fill_recv in virtnet_poll |
| |
On Tue 15-02-11 20:41:29, Rusty Russell wrote: > On Tue, 15 Feb 2011 08:05:27 pm Michal Hocko wrote: > > Hi, > > we have started seeing a lot of allocator messages complaining about > > failed allocations from virtnet_poll in soft IRQ. Could you consider the > > following patch, please? > > Do we really want to silence this? Isn't warning about it kind of the > point? Your network is probably sucking if this happens...
What can user do about it? Is the low level memory allocator message very much usefull for him? Maybe we can add a printk_once in the fail path with some more useful and virtio specific message.
Thanks -- Michal Hocko SUSE Labs SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic
| |