Messages in this thread | | | Date | Tue, 15 Feb 2011 23:48:14 +0100 (CET) | From | Jiri Kosina <> | Subject | Re: [PATCH] hidinput: kernel oops in out_cleanup in function hidinput_connect |
| |
On Tue, 15 Feb 2011, Dmitry Torokhov wrote:
> > Goto out_cleanup infers a kernel oops: hidinput_disconnect calls > > input_unregister_driver to all members of hid->inputs. > > However, hidinput already has been added to hid->inputs even > > though input_register_device was not called. > > > > Signed-off-by: Benjamin Tissoires <benjamin.tissoires@enac.fr> > > Yep, well spotted. > > Reviewed-by: Dmitry Torokhov <dtor@mail.ru>
Indeed, thanks a lot for spotting this Benjamin. Apparently this codepath is not excercised too heavily (which is good :) ).
Applied.
-- Jiri Kosina SUSE Labs, Novell Inc.
| |