lkml.org 
[lkml]   [2011]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [dm-devel] [PATCH][RFC] dm: Do not open log and cow device read-write for read-only mappings
On Tue, Feb 15, 2011 at 05:05:48PM +0100, Milan Broz wrote:
> On 02/15/2011 04:50 PM, Tejun Heo wrote:
> >> That's why I'm arguing EACCES is not a good error to return and EROFS is
> >> more appropriate.
> >
> > Frankly, I don't really mind one way or the other but EROFS isn't
> > usually used in those areas. It might make sense for this use case
> > and then there will be cases it just feels awkward. This being a dm
> > thing, wouldn't it be just better to let dm massage the return value?
>
> It is not DM thing. That code was checking for generic block device.
> No DM there (it was from cryptsetup code but not related to DM part).

Hmmm... I'm confused now. Where was that -EROFS from then? I don't
recall changing -EROFS to -EACCES. What did I miss?

--
tejun


\
 
 \ /
  Last update: 2011-02-15 17:15    [W:1.051 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site