lkml.org 
[lkml]   [2011]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] bluetooth: bnep: fix buffer overflow
    Date
    Struct ca is copied from userspace.  It is not checked whether the "device"
    field is NULL terminated. This potentially leads to BUG() inside of
    alloc_netdev_mqs() and/or information leak by creating a device with a name
    made of contents of kernel stack.

    Signed-off-by: Vasiliy Kulikov <segoon@openwall.com>
    ---
    Compile tested.

    net/bluetooth/bnep/sock.c | 1 +
    1 files changed, 1 insertions(+), 0 deletions(-)

    diff --git a/net/bluetooth/bnep/sock.c b/net/bluetooth/bnep/sock.c
    index 2862f53..30faaf1 100644
    --- a/net/bluetooth/bnep/sock.c
    +++ b/net/bluetooth/bnep/sock.c
    @@ -88,6 +88,7 @@ static int bnep_sock_ioctl(struct socket *sock, unsigned int cmd, unsigned long
    sockfd_put(nsock);
    return -EBADFD;
    }
    + ca.device[sizeof(ca.device)-1] = 0;

    err = bnep_add_connection(&ca, nsock);
    if (!err) {
    --
    1.7.0.4


    \
     
     \ /
      Last update: 2011-02-14 11:57    [W:6.655 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site