Messages in this thread | | | Subject | Re: [PATCH 2/5] drivers/char/hw_random/omap-rng.c: Convert release_resource to release_region/release_mem_region | From | Matt Mackall <> | Date | Mon, 14 Feb 2011 16:42:24 -0600 |
| |
On Sun, 2011-02-13 at 13:12 +0100, Julia Lawall wrote: > Request_region should be used with release_region, not release_resource. > > The local variable mem, storing the result of request_mem_region, is > dropped and instead the pointer res is stored in the drvdata field of the > platform device. This information is retrieved in omap_rng_remove to > release the region. The drvdata field is not used elsewhere. > > The semantic match that finds this problem is as follows: > (http://coccinelle.lip6.fr/)
Looks ok to me, Herbert?
-- Mathematics is the supreme nostalgia of our time.
| |