Messages in this thread | | | Date | Sun, 13 Feb 2011 15:11:10 +0100 | From | Milan Broz <> | Subject | Re: [PATCH] loop: clear read-only flag in loop_clr_fd. |
| |
On 02/13/2011 11:58 AM, Tao Ma wrote: > From: Tao Ma <boyu.mt@taobao.com> > > In 75f1dc0, we check bdev_read_only() from blkdev_get(). > But the loop_clr_fd doesn't clear the read only flag. > What cause a error if we changing a loop device from > read only to writable.
No, sorry, this is not proper/complete fix. It fixes it for loop (and even not completely - you are missing some error paths and ignoring autoclear mode where you have bdev NULL.) (And yes, I tried the same as workaround.)
And it will not help for DM case (and possibly others).
Milan
| |