Messages in this thread Patch in this message | | | Date | Sun, 13 Feb 2011 14:37:18 +0100 | From | Kurt Van Dijck <> | Subject | Re: [PATCH -next/mmotm] net/can: fix softing build errors |
| |
On Sat, Feb 12, 2011 at 08:02:42AM -0800, Randy Dunlap wrote: > On 02/12/11 03:15, Kurt Van Dijck wrote: > > On Fri, Feb 11, 2011 at 10:33:12PM -0800, Randy Dunlap wrote: > >> > >> warning: (CAN_SOFTING_CS) selects CAN_SOFTING which has unmet direct dependencies (NET && CAN && CAN_DEV && HAS_IOMEM) > >> > >> with this partial config: > >> > >> CONFIG_CAN=m > >> # CONFIG_CAN_RAW is not set > >> # CONFIG_CAN_BCM is not set > >> # CAN Device Drivers > >> # CONFIG_CAN_VCAN is not set > >> CONFIG_CAN_SLCAN=m > >> # CONFIG_CAN_DEV is not set > >> CONFIG_CAN_SOFTING=m > >> CONFIG_CAN_SOFTING_CS=m > >> # CONFIG_CAN_DEBUG_DEVICES is not set > > I understand the output, but I don't understand the cause well enough. > > CAN_SOFTING=m has a 'depends on CAN_DEV' > > Is it then possible to have CAN_SOFTING=m _and not_ CAN_DEV ? > > Yes. From Documentation/kbuild/kconfig-language.txt: > I see. The 'select CAN_SOFTING' was introduced because it makes no sense to have CAN_SOFTING_CS alone 'for a normal user', although there is no real dependency. Is a 'select' then still a good option, since it feels like repeating all dependencies from CAN_SOFTING in CAN_SOFTING_CS? What about this?
diff --git a/drivers/net/can/softing/Kconfig b/drivers/net/can/softing/Kconfig index 92bd6bd..55dd3e4 100644 --- a/drivers/net/can/softing/Kconfig +++ b/drivers/net/can/softing/Kconfig @@ -18,7 +18,7 @@ config CAN_SOFTING config CAN_SOFTING_CS tristate "Softing Gmbh CAN pcmcia cards" depends on PCMCIA - select CAN_SOFTING + depends on CAN_SOFTING ---help--- Support for PCMCIA cards from Softing Gmbh & some cards from Vector Gmbh. --- It will present the Softing stuff in Kconfig as if CAN_SOFTING_CS really depends on CAN_SOFTING, which is acceptible from a users perspective. Kurt
| |