Messages in this thread | | | Date | Sat, 12 Feb 2011 08:04:04 -0800 | From | Greg KH <> | Subject | Re: [PATCH] usb: gadget: f_mass_storage: fixed a macro coding style issue |
| |
On Sat, Feb 12, 2011 at 04:15:21PM +0800, yenchengwang wrote: > ah, I think I made a mistake... > I watched this video > http://archive.fosdem.org/2010/schedule/events/linuxkernelpatch, > then tried the ./scripts/checkpatch.pl and see two ERROR:... > so ... sent this patch, I apologize for my mistake, :(
That's great to do that, but you forgot the part of that talk that showed you had to build your patch to verify that you did not break anything. Please do that in the future.
thanks,
greg k-h
| |