Messages in this thread | | | Date | Sat, 12 Feb 2011 10:04:15 -0800 | From | Yinghai Lu <> | Subject | Re: [PATCH 02/26] x86-64, NUMA: Simplify hotplug node handling in acpi_numa_memory_affinity_init() |
| |
On 02/12/2011 09:56 AM, Tejun Heo wrote: > On Sat, Feb 12, 2011 at 6:47 PM, Yinghai Lu <yinghai@kernel.org> wrote: >>> - if ((nd->start | nd->end) == 0) >>> - node_clear(node, nodes_parsed); >> >> after change >> looks like nodes_parsed is not set anymore for node that only have hotplug memory. > > Yeap, which matches the above node_clear(). If the node was already > occupied, the bit would already be set. If not, the above > node_clear() would clear it, so the same result. The code was quite > convoluted.
no. if the node only have hotplug mem. then nd->start and nd->end will be set to that hot plug range. and old code does not clear nodes_parsed...
Yinghai
| |