lkml.org 
[lkml]   [2011]   [Dec]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 1/1] input: keyboard: Set configuration registers
Date
On Friday, December 09, 2011 12:10:43 PM Stephen Warren wrote:
> Shridhar Rasal wrote at Friday, December 09, 2011 12:29 AM:
> > To: dmitry.torokhov@gmail.com
> > Cc: rydberg@euromail.se; Stephen Warren; Rakesh Iyer;
> > linux-kernel@vger.kernel.org; linux- input@vger.kernel.org;
> > linux-tegra@vger.kernel.org; Shridhar Rasal Subject: [PATCH 1/1] input:
> > keyboard: Set configuration registers
> >
> > -Set only REQUIRED row and column configuration register to
> > PROPER values to avoid continuously generating KBC input events.
> > -Use *en* field in pin_cfg, to check GPIO_x_ROW_EN register
> > should be set or clear.
> >
> > Signed-off-by: Shridhar Rasal <srasal@nvidia.com>
>
> I wondered if num==0 could be used instead of a new en field, but 0 is a
> valid row/column number, so no. As such,
>
> Acked-by: Stephen Warren <swarren@nvidia.com>

Can we pass in number of pin_cfg instances in pdata and simply do not
mention unneeded pins instead?

Thanks.

--
Dmitry


\
 
 \ /
  Last update: 2011-12-09 22:27    [W:0.048 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site