lkml.org 
[lkml]   [2011]   [Dec]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] USB: Adding #define in hub_configure() and hcd.c file
On Thu, 8 Dec 2011, Aman Deep wrote:

> This patch is in succession of previous patch
> commit c8421147926fcacf53081a36438a0bed394da9f5
> xHCI: Adding #define values used for hub descriptor
>
> Hub descriptors characteristics #defines values are added in
> hub_configure() in place of magic numbers as asked by Alan Stern.
> And the indentation for switch and case is changed to be same.
>
> Some #defines values are added in ch11.h for defining hub class
> protocols and used in hub.c and hcd.c in which magic values were
> used for hub class protocols.
>
> Signed-off-by: Aman Deep <amandeep3986@gmail.com>

I like it!

If you're looking for more things to work on, consider the #defines in
ch11.h for the various port features and statuses. Some of the newer
USB-3 entries were added in the wrong place, or even added twice! It
would be good to get that straightened up.

Alan Stern



\
 
 \ /
  Last update: 2011-12-09 16:45    [W:0.031 / U:0.164 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site