lkml.org 
[lkml]   [2011]   [Dec]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRE: [PATCH v8 1/9] Basic kernel memory functionality for the Memory Controller
Date
From

> How about this?
>
> val = !!val;
>
> /*
> * This follows the same hierarchy restrictions than
> * mem_cgroup_hierarchy_write()
> */
> if (!parent || !parent->use_hierarchy) {
> if (list_empty(&cgroup->children))
> memcg->kmem_independent_accounting = val;
> else
> return -EBUSY;
> }
> else
> return -EINVAL;
>
> return 0;

Inverting the tests gives easier to read code:

if (parent && parent->user_hierarchy)
return -EINVAL;
if (!list_empty(&cgroup->children))
return -EBUSY;
memcg->kmem_independent_accounting = val != 0;
return 0;

NFI about the logic...
On the face of it the tests don't seem related to each other
or to the assignment!

David






\
 
 \ /
  Last update: 2011-12-09 15:47    [W:0.532 / U:0.308 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site