Messages in this thread | | | Date | Fri, 09 Dec 2011 14:52:46 +0100 | From | Marc Kleine-Budde <> | Subject | Re: [PATCH] flexcan: Acknowledge all interrupt sources in the IRQ handler |
| |
On 12/09/2011 02:47 PM, Lothar Waßmann wrote: > Otherwise the handler will get stuck in an endless IRQ loop when an > interrupt condition occurs that is not being acked (e.g. TWRN)
On which CPU do you have this problem?
Seems that mx25/35 behave a bit different than mx28. But I had no time to dig into this, yet. BTW Wolfgang is just reworking error handling, can you please test his patches he recently posted on linux-can.
cheers, Marc
> Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de> > --- > drivers/net/can/flexcan.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/net/can/flexcan.c b/drivers/net/can/flexcan.c > index e023379..ea8f04d 100644 > --- a/drivers/net/can/flexcan.c > +++ b/drivers/net/can/flexcan.c > @@ -577,7 +577,7 @@ static irqreturn_t flexcan_irq(int irq, void *dev_id) > > reg_iflag1 = flexcan_read(®s->iflag1); > reg_esr = flexcan_read(®s->esr); > - flexcan_write(FLEXCAN_ESR_ERR_INT, ®s->esr); /* ACK err IRQ */ > + flexcan_write(reg_esr, ®s->esr); /* ACK all IRQs */ > > /* > * schedule NAPI in case of:
-- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[unhandled content-type:application/pgp-signature] | |