Messages in this thread | | | Date | Thu, 08 Dec 2011 00:30:40 +0800 | From | "Ying-Chun Liu (PaulLiu)" <> | Subject | Re: [PATCH] Regulator: Add Anatop regulator driver |
| |
(2011年12月07日 23:54), Mark Brown wrote: > On Wed, Dec 07, 2011 at 09:53:18PM +0800, Ying-Chun Liu (PaulLiu) wrote: >> From: "Ying-Chun Liu (PaulLiu)" <paul.liu@linaro.org> >> >> Anatop regulator driver is used by i.MX6 SoC. This patch adds the >> Anatop regulator driver. > > This changelog isn't terribly verbose but looking at the code what > you've actually got here is a driver that is simply an indirection > layer for the regulator API and no explanation as to why you're doing > this. My first thought is that anything using this driver should just > be a regulator driver directly.
Hi Mark,
Thanks. I think you are correct. I just search the LKML and found that this has been discussed already. https://lkml.org/lkml/2011/10/28/325
So what we should do is forget this patch and use fixed regulators rather than create an indirection layer.
Many Thanks, Paul
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |