Messages in this thread | | | Date | Mon, 5 Dec 2011 17:06:46 +0000 | From | Mel Gorman <> | Subject | Re: Question about __zone_watermark_ok: why there is a "+ 1" in computing free_pages? |
| |
On Mon, Dec 05, 2011 at 05:14:43PM +0100, Michal Hocko wrote: > From 38a1cf351b111e8791d2db538c8b0b912f5df8b8 Mon Sep 17 00:00:00 2001 > From: Michal Hocko <mhocko@suse.cz> > Date: Mon, 5 Dec 2011 17:04:23 +0100 > Subject: [PATCH] mm: fix off-by-two in __zone_watermark_ok > > 88f5acf8 [mm: page allocator: adjust the per-cpu counter threshold when > memory is low] changed the form how free_pages is calculated but it > forgot that we used to do free_pages - ((1 << order) - 1) so we ended up > with off-by-two when calculating free_pages. > > Spotted-by: Wang Sheng-Hui <shhuiw@gmail.com> > Signed-off-by: Michal Hocko <mhocko@suse.cz>
Acked-by: Mel Gorman <mgorman@suse.de>
-- Mel Gorman SUSE Labs
| |