Messages in this thread | | | Date | Sun, 4 Dec 2011 15:54:35 +0000 | From | Mark Brown <> | Subject | Re: [PATCH v5 1/4] regulator: helper routine to extract regulator_init_data |
| |
On Sun, Dec 04, 2011 at 06:51:23PM +0530, Thomas Abraham wrote:
> For regulators that are not turned on by bootloader, and which require > 'apply_uV' constraint, is there any alternative for turning on the > regulator when using dt?
If the regulator isn't software managed then always_on covers this - the regulator core will enable any always_on regulators that haven't been enabled already.
> /* do we need to apply the constraint voltage */ > - if (rdev->constraints->apply_uV && > - rdev->constraints->min_uV == rdev->constraints->max_uV) { > + if ((rdev->constraints->apply_uV && > + rdev->constraints->min_uV == rdev->constraints->max_uV) || > + (!rdev->constraints->boot_on && rdev->constraints->always_on)) { > ret = _regulator_do_set_voltage(rdev, > rdev->constraints->min_uV, > rdev->constraints->max_uV);
I'm not sure I understand the intended logic there. Voltage constraints and enable/disable constraints are orthogonal here.
| |