lkml.org 
[lkml]   [2011]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 1/4] regulator: helper routine to extract regulator_init_data
On Sun, Dec 04, 2011 at 06:51:23PM +0530, Thomas Abraham wrote:

> For regulators that are not turned on by bootloader, and which require
> 'apply_uV' constraint, is there any alternative for turning on the
> regulator when using dt?

If the regulator isn't software managed then always_on covers this - the
regulator core will enable any always_on regulators that haven't been
enabled already.

> /* do we need to apply the constraint voltage */
> - if (rdev->constraints->apply_uV &&
> - rdev->constraints->min_uV == rdev->constraints->max_uV) {
> + if ((rdev->constraints->apply_uV &&
> + rdev->constraints->min_uV == rdev->constraints->max_uV) ||
> + (!rdev->constraints->boot_on && rdev->constraints->always_on)) {
> ret = _regulator_do_set_voltage(rdev,
> rdev->constraints->min_uV,
> rdev->constraints->max_uV);

I'm not sure I understand the intended logic there. Voltage constraints
and enable/disable constraints are orthogonal here.


\
 
 \ /
  Last update: 2011-12-04 16:57    [W:0.128 / U:0.316 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site