Messages in this thread | | | Date | Wed, 28 Dec 2011 14:00:48 +0900 | From | Donggeun Kim <> | Subject | Re: [PATCH v3 1/2] power: Charger-Manager: add initial Charger-Manager driver |
| |
On 2011년 12월 27일 20:36, Mark Brown wrote: > On Tue, Dec 27, 2011 at 06:47:48PM +0900, Donggeun Kim wrote: > >> + /* >> + * Abnormal battery state - Stop charging forcibly, >> + * even if charger was enabled at the other places >> + */ >> + err = regulator_bulk_disable(desc->num_charger_regulators, >> + desc->charger_regulators); >> + >> + for (i = 0; i < desc->num_charger_regulators; i++) { >> + if (regulator_is_enabled( >> + desc->charger_regulators[i].consumer)) { >> + regulator_force_disable( >> + desc->charger_regulators[i].consumer); >> + dev_warn(cm->dev, >> + "Disable regulator(%s) forcibly.\n", >> + desc->charger_regulators[i].supply); >> + } > > Just implement a regulator_bulk_force_disable() operation; this is a > totally reasonable thing to want to do and other drivers may have the > same need. Actually, looking at what you've written here it's totally > sensible and we should probably also roll the attempt to do a normal > disable() into force_disable() - there can't be many situations in which > trying a clean shutdown first isn't the right thing to do. > Okay. The patch for 'regulator_bulk_force_disable' will be sent regardless of this patchset.
Thanks. -Donggeun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |