Messages in this thread Patch in this message | | | From | Julia Lawall <> | Subject | [PATCH 5/6] drivers/char/hw_random/tx4939-rng.c: use devm_request_and_ioremap | Date | Tue, 27 Dec 2011 15:01:30 +0100 |
| |
From: Julia Lawall <julia@diku.dk>
Reimplement a call to devm_request_mem_region followed by a call to ioremap or ioremap_nocache by a call to devm_request_and_ioremap.
The semantic patch that makes this transformation is as follows: (http://coccinelle.lip6.fr/)
// <smpl> @nm@ expression myname; identifier i; @@
struct platform_driver i = { .driver = { .name = myname } };
@@ expression dev,res,size; expression nm.myname; @@
-if (!devm_request_mem_region(dev, res->start, size, - \(res->name\|dev_name(dev)\|myname\))) { - ... - return ...; -} ... when != res->start ( -devm_ioremap(dev,res->start,size) +devm_request_and_ioremap(dev,res) | -devm_ioremap_nocache(dev,res->start,size) +devm_request_and_ioremap(dev,res) ) ... when any when != res->start // </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
--- drivers/char/hw_random/tx4939-rng.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/char/hw_random/tx4939-rng.c b/drivers/char/hw_random/tx4939-rng.c index 0bc0cb7..de473ef 100644 --- a/drivers/char/hw_random/tx4939-rng.c +++ b/drivers/char/hw_random/tx4939-rng.c @@ -115,10 +115,7 @@ static int __init tx4939_rng_probe(struct platform_device *dev) rngdev = devm_kzalloc(&dev->dev, sizeof(*rngdev), GFP_KERNEL); if (!rngdev) return -ENOMEM; - if (!devm_request_mem_region(&dev->dev, r->start, resource_size(r), - dev_name(&dev->dev))) - return -EBUSY; - rngdev->base = devm_ioremap(&dev->dev, r->start, resource_size(r)); + rngdev->base = devm_request_and_ioremap(&dev->dev, r); if (!rngdev->base) return -EBUSY;
| |