lkml.org 
[lkml]   [2011]   [Dec]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -next] rcu: add missing __cpuinit annotation in rcutorture code
On Tue, Dec 27, 2011 at 03:04:26PM +0100, Heiko Carstens wrote:
> "rcu: Add rcutorture CPU-hotplug capability" adds cpu hotplug operations
> to the rcutorture code but produces a false positive warning about section
> mismatches:
>
> WARNING: vmlinux.o(.text+0x1e420c): Section mismatch in reference from the
> function rcu_torture_onoff() to the function .cpuinit.text:cpu_up()
> The function rcu_torture_onoff() references
> the function __cpuinit cpu_up().
> This is often because rcu_torture_onoff lacks a __cpuinit
> annotation or the annotation of cpu_up is wrong.
>
> Just add a __cpuinit annotation so the warning goes away.
>
> Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>

Thank you -- queued on my local -rcu tree.

Thanx, Paul

> ---
> kernel/rcutorture.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/rcutorture.c b/kernel/rcutorture.c
> index e29edc3..a58ac28 100644
> --- a/kernel/rcutorture.c
> +++ b/kernel/rcutorture.c
> @@ -1399,7 +1399,7 @@ rcu_torture_shutdown(void *arg)
> * Execute random CPU-hotplug operations at the interval specified
> * by the onoff_interval.
> */
> -static int
> +static int __cpuinit
> rcu_torture_onoff(void *arg)
> {
> int cpu;
> @@ -1447,7 +1447,7 @@ rcu_torture_onoff(void *arg)
> return 0;
> }
>
> -static int
> +static int __cpuinit
> rcu_torture_onoff_init(void)
> {
> if (onoff_interval <= 0)
> --
> 1.7.7.3
>



\
 
 \ /
  Last update: 2011-12-27 18:33    [W:0.037 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site