lkml.org 
[lkml]   [2011]   [Dec]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -next] debugfs: add missing #ifdef HAS_IOMEM
> "debugfs: add tools to printk 32-bit registers" adds new functions
> which rely on IOMEM functionality which is not present on all
> architectures and therefore result in compile errors:

Ok, my fault. I was thinking everybody has it.

Acked-by: Alessandro Rubini <rubini@gnudd.com>

(on the other hand, maybe the header should have it as well? I hate
ifdef so I'd better avoid it, but I don't know what the policy is in
this case: compile-error for implicit declaration or link error for
missing symbol? -- maybe a comment in the header is suitable?).

/alessandro


\
 
 \ /
  Last update: 2011-12-27 15:29    [W:0.039 / U:0.660 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site