Messages in this thread | | | Date | Thu, 22 Dec 2011 09:22:43 +0100 | From | Andi Kleen <> | Subject | Re: [PATCH] VFS: br_write_lock locks on possible CPUs other than online CPUs |
| |
On Wed, Dec 21, 2011 at 11:20:47PM -0800, Andrew Morton wrote: > On Thu, 22 Dec 2011 07:02:15 +0000 Al Viro <viro@ZenIV.linux.org.uk> wrote: > > > On Wed, Dec 21, 2011 at 02:12:29PM -0800, Andrew Morton wrote: > > > off-topic, but the lockdep stuff in include/linux/lglock.h > > > (LOCKDEP_INIT_MAP and DEFINE_LGLOCK_LOCKDEP) appears to be dead code. > > > > Um? See ..._lock_init(); it's used there. > > oops, I had Andi's patch applied. > > Wanna take a look at it while things are fresh in your mind?
Double checked: DEFINE_LGLOCK_LOCKDEP is dead now and can be removed. The stuff it declared is in the struct lglock now.
I can send a patch for that tomorrow if you haven't done it already.
LOCKDEP_INIT_MAP should be still used in lg_lock_init() and that is called
-Andi
| |