Messages in this thread | | | Date | Thu, 22 Dec 2011 09:06:34 +0100 | From | Michal Simek <> | Subject | Re: [PATCH 4/4] microblaze: Remove NO_IRQ from architecture |
| |
Ryan Mallon wrote: > On 22/12/11 01:32, Michal Simek wrote: > >> NO_IRQ shouldn't be used by any driver. All Microblaze >> drivers are fixed that's why NO_IRQ can be removed. > > > This only describes half of what the patch does. You should also state > that arch/microblaze/pci/pci-common.c has references to NO_IRQ removed. > Maybe it' worth splitting this patch in half so the final patch just > does the removal of the NO_IRQ definition, but maybe that is overkill?
I have decided to remove NO_IRQ from arch/microblaze in one patch. It is less painful because if there is any problem with PCI you can revert just one patch instead of two.
Drivers out of arch/microblaze must be in separate patches.
> Other than that, for the whole series: > > Reviewed-by: Ryan Mallon <rmallon@gmail.com>
Thanks, Michal
-- Michal Simek, Ing. (M.Eng) w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/ Microblaze U-BOOT custodian
| |