Messages in this thread | | | From | Linus Torvalds <> | Date | Thu, 22 Dec 2011 11:44:16 -0800 | Subject | Re: [PATCH 2/3] block: fail SCSI passthrough ioctls on partition devices |
| |
On Thu, Dec 22, 2011 at 11:18 AM, Paolo Bonzini <pbonzini@redhat.com> wrote: >> >> This kind of crazy needs to go away. > > What crazy? It's not a permission problem. Sending a SCSI command to a > partition makes no sense. A permission problem implies that somehow you > should be able to fix it by granting additional permissions, which is not > the case here.
Ahh, I misread the intention here, and didn't notice that it was doing it on the stupid SCSI ioctl commands, not the lowlevel SCSI "cmd". The fact that the changelog talked about sending read/write commands down to the disk confused me.
But please do use ENOIOCTLCMD directly then, instead of using ENOTTY and turning it into ENOIOCTLCMD.
Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |