lkml.org 
[lkml]   [2011]   [Dec]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3 v5] sound/soc/codecs: add LAPIS Semiconductor ML26124
On Thu, Dec 22, 2011 at 05:31:08PM +0900, Tomoya MORINAGA wrote:
> 2011/12/20 Mark Brown <broonie@opensource.wolfsonmicro.com>:

> > How have you tested this code?

> No, I haven't tested at all. (Of course, I tested before ASoC.)
> I'll test the new these drivers after you say "Roughly, how to use
> ASoC framework is OK"

Don't do this unless you really have to, and if for some reason it's
needed or useful then indicate that this is what you're doing. People
shouldn't be finding issues on review that mean that the code will never
run. If the testing is very light that's fine but you need to make some
effort to verify that things will work.


\
 
 \ /
  Last update: 2011-12-22 11:53    [W:0.075 / U:0.376 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site