lkml.org 
[lkml]   [2011]   [Dec]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/3] HID: usbhid: defer LED setting to a workqueue
On Tue, 20 Dec 2011, Oliver Neukum wrote:

> > > > Could you please be more specific about what this patch breaks and
> > > > perhaps give some guidance on how to fix it?
> > >
> > > It breaks nothing. It just continues a bug and I assumed it was not present.
> > > Basically the work queue must do nothing after pre_reset() and post_reset()
> > > ought to rerun the work in case some request came down during that time.
> >
> > So, is this an Ack for this patchset?
> > Can we fix any existing races in later patches?
>
> Very well. You are fixing a bad bug and not making matters worse.
>
> Acked-by: Oliver Neukum <oneukum@suse.de>

Thanks guys. Applied.

--
Jiri Kosina
SUSE Labs


\
 
 \ /
  Last update: 2011-12-21 11:21    [W:0.075 / U:0.232 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site