Messages in this thread | | | Date | Wed, 21 Dec 2011 11:19:26 +0100 (CET) | From | Jiri Kosina <> | Subject | Re: [PATCH 3/3] HID: usbhid: defer LED setting to a workqueue |
| |
On Tue, 20 Dec 2011, Oliver Neukum wrote:
> > > > Could you please be more specific about what this patch breaks and > > > > perhaps give some guidance on how to fix it? > > > > > > It breaks nothing. It just continues a bug and I assumed it was not present. > > > Basically the work queue must do nothing after pre_reset() and post_reset() > > > ought to rerun the work in case some request came down during that time. > > > > So, is this an Ack for this patchset? > > Can we fix any existing races in later patches? > > Very well. You are fixing a bad bug and not making matters worse. > > Acked-by: Oliver Neukum <oneukum@suse.de>
Thanks guys. Applied.
-- Jiri Kosina SUSE Labs
| |