Messages in this thread | | | Date | Wed, 21 Dec 2011 10:06:07 +0200 | Subject | Re: [GIT PULL] slab fixes for 3.2-rc4 | From | Pekka Enberg <> |
| |
On Tue, 20 Dec 2011, Pekka Enberg wrote: >> To illustrate the issue, for "per cpu add" we have: >> >> __this_cpu_add() >> this_cpu_add() >> irqsafe_cpu_add() >> percpu_add() >> >> Why do we need all of them?
On Tue, Dec 20, 2011 at 6:26 PM, Christoph Lameter <cl@linux.com> wrote: > These are all operations that frequently occur in hot paths of the OS.
It's a provably difficult API to use that has pretty much zero debugging code. That's a problem.
I still don't understand why we'd want separate preempt safe and irqsafe variants. It should be enough to have only unsafe and safe variants where the latter would always do the right thing.
Pekka
| |