Messages in this thread | | | Subject | Re: [PATCH] vmalloc: remove #ifdef in function body | Date | Wed, 21 Dec 2011 07:24:05 +0100 | From | "Michal Nazarewicz" <> |
| |
On Wed, 21 Dec 2011 07:22:32 +0100, Minchan Kim <minchan@kernel.org> wrote:
> On Wed, Dec 21, 2011 at 07:13:49AM +0100, Michal Nazarewicz wrote: >> On Wed, 21 Dec 2011 06:17:59 +0100, Minchan Kim <minchan@kernel.org> wrote: >> >We don't like function body which include #ifdef. >> >If we can, define null function to go out compile time. >> >It's trivial, no functional change. >> >> It actually adds “flush_tlb_kenel_range()” call to the function so there >> is functional change. > > Sorry. I can't understand your point. > Why does it add flush_tlb_kernel_range in case of !CONFIG_DEBUG_PAGEALLOC?
Uh, sorry, I've totally misread the function. Never mind my comment.
-- Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o ..o | Computer Science, Michał “mina86” Nazarewicz (o o) ooo +----<email/xmpp: mpn@google.com>--------------ooO--(_)--Ooo-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |