lkml.org 
[lkml]   [2011]   [Dec]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[tip:sched/core] sched: Remove cfs bandwidth period check in tg_set_cfs_period()
Commit-ID:  11534ec5b6cea13ae38d31799d2a5290c5d724af
Gitweb: http://git.kernel.org/tip/11534ec5b6cea13ae38d31799d2a5290c5d724af
Author: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
AuthorDate: Sat, 10 Dec 2011 19:29:25 +0530
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Wed, 21 Dec 2011 10:34:48 +0100

sched: Remove cfs bandwidth period check in tg_set_cfs_period()

Remove cfs bandwidth period check from tg_set_cfs_period.
Invalid bandwidth period's lower/upper limits are denoted
by min_cfs_quota_period/max_cfs_quota_period repsectively,
and are checked against valid period in tg_set_cfs_bandwidth().

As pjt pointed out, negative input will result in very large unsigned
numbers and will be caught by the max allowed period test.

Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Acked-by: Paul Turner <pjt@google.com>
[ammended changelog to mention negative values]
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/20111210135925.GA14593@linux.vnet.ibm.com
--
kernel/sched/core.c | 3 ---
1 file changed, 3 deletions(-)

Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
kernel/sched/core.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index dba878c..081ece2 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -7714,9 +7714,6 @@ int tg_set_cfs_period(struct task_group *tg, long cfs_period_us)
period = (u64)cfs_period_us * NSEC_PER_USEC;
quota = tg->cfs_bandwidth.quota;

- if (period <= 0)
- return -EINVAL;
-
return tg_set_cfs_bandwidth(tg, period, quota);
}


\
 
 \ /
  Last update: 2011-12-21 12:47    [W:0.048 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site