Messages in this thread | | | Subject | Re: [PATCH 2/8] farsync: Fix confusion about DMA address and buffer offset types | From | Ben Hutchings <> | Date | Wed, 21 Dec 2011 05:41:13 +0000 |
| |
On Tue, 2011-12-20 at 23:46 -0500, David Miller wrote: > From: Ben Hutchings <ben@decadent.org.uk> > Date: Wed, 21 Dec 2011 01:32:52 +0000 > > > - dbg(DBG_RX, "In fst_rx_dma %lx %lx %d\n", > > - (unsigned long) skb, (unsigned long) mem, len); > > + dbg(DBG_RX, "In fst_rx_dma %x %x %d\n", (u32)skb, mem, len); > > This is more appropriately fixed by using "%p" instead of casting > to a 32-bit int.
'skb' is the physical address of the data in the skb. Whereas 'mem' is the offset of the corresponding buffer in shared memory.
All completely clear, right? ;-)
Ben.
-- Ben Hutchings Humans are not rational beings; they are rationalising beings. [unhandled content-type:application/pgp-signature] | |