Messages in this thread | | | Date | Tue, 20 Dec 2011 17:45:58 -0500 | From | Ted Ts'o <> | Subject | Re: [PATCH] mm: add missing mutex lock arround notify_change |
| |
I just took a closer look, and we don't need to take immediate action; there is no security issue here were someone could modify a writable suid file as I had originally feared. It's not as obvious as it could be because of how the code is broken up, but in mext_check_arguments() in fs/ext4/move_extent.c, we return with an error if the donor file has the SUID or SGID bit set, so we'll never actually end up calling file_remove_suid(). So in fact the right patch is just to remove the call to file_remove_suid() altogether.
- Ted
| |