Messages in this thread Patch in this message | | | From | "Nandigama, Nagalakshmi" <> | Date | Mon, 19 Dec 2011 14:08:16 +0530 | Subject | RE: [PATCH] [SCSI] mptfusion: Use kmemdup rather than duplicating its implementation |
| |
This patch seem to be fine. Please consider this patch as acked by me.
Regards, Nagalakshmi
-----Original Message----- From: Thomas Meyer [mailto:thomas@m3y3r.de] Sent: Friday, November 18, 2011 4:14 AM To: DL-MPT Fusion Linux; linux-scsi@vger.kernel.org; linux-kernel@vger.kernel.org Subject: [PATCH] [SCSI] mptfusion: Use kmemdup rather than duplicating its implementation
The semantic patch that makes this change is available in scripts/coccinelle/api/memdup.cocci.
Signed-off-by: Thomas Meyer <thomas@m3y3r.de> ---
diff -u -p a/drivers/message/fusion/mptbase.c b/drivers/message/fusion/mptbase.c --- a/drivers/message/fusion/mptbase.c 2011-11-07 19:37:51.796676955 +0100 +++ b/drivers/message/fusion/mptbase.c 2011-11-08 10:40:23.121014643 +0100 @@ -6003,13 +6003,12 @@ mpt_findImVolumes(MPT_ADAPTER *ioc) if (mpt_config(ioc, &cfg) != 0) goto out; - mem = kmalloc(iocpage2sz, GFP_KERNEL); + mem = kmemdup((u8 *)pIoc2, iocpage2sz, GFP_KERNEL); if (!mem) { rc = -ENOMEM; goto out; } - memcpy(mem, (u8 *)pIoc2, iocpage2sz); ioc->raid_data.pIocPg2 = (IOCPage2_t *) mem; mpt_read_ioc_pg_3(ioc); | |