lkml.org 
[lkml]   [2011]   [Dec]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 03/10] crypto: Add support for x86 cpuid auto loading for x86 crypto drivers
On Mon, Dec 19, 2011 at 03:25:06PM -0800, H. Peter Anvin wrote:

> > > - if (!cpu_has_phe) {
> > > - printk(KERN_NOTICE PFX "VIA PadLock Hash Engine not detected.\n");
> > > - return -ENODEV;
> > > - }
> > > -
> > > - if (!cpu_has_phe_enabled) {
> > > - printk(KERN_NOTICE PFX "VIA PadLock detected, but not enabled. Hmm, strange...\n");
> > > + if (!x86_match_cpu(padlock_sha_ids) || !cpu_has_phe_enabled)
> > > return -ENODEV;
> > > - }
> >
> > don't we want to keep the printk ?
> >
> > Seems that if it's been disabled by the BIOS for some reason, it will now
> > silently fail instead of printing a nice warning.
>
> The first printk is insanely annoying, because the end result is that we
> get a printk of all the crypto engines that are *not* enabled...
> arguably it would be somewhat nice to get a printk when a crypto engine
> *is* enabled.

Sorry, I just meant the second printk, which should hopefully not get
printed by default.

Dave



\
 
 \ /
  Last update: 2011-12-20 00:35    [W:0.123 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site