Messages in this thread | | | Date | Mon, 19 Dec 2011 16:04:41 +0100 | From | Johannes Weiner <> | Subject | Re: [PATCH 1/4] memcg: simplify page cache charging. |
| |
On Wed, Dec 14, 2011 at 04:49:22PM +0900, KAMEZAWA Hiroyuki wrote: > From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> > > This patch is a clean up. No functional/logical changes. > > Because of commit ef6a3c6311, FUSE uses replace_page_cache() instead > of add_to_page_cache(). Then, mem_cgroup_cache_charge() is not > called against FUSE's pages from splice. > > So, Now, mem_cgroup_cache_charge() doesn't receive a page on LRU > unless it's not SwapCache. > For checking, WARN_ON_ONCE(PageLRU(page)) is added. > > Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
I like this.
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
| |