Messages in this thread | | | From | Marek Vasut <> | Subject | Re: checkpatch.pl misreporting bugs with array fillings | Date | Sat, 17 Dec 2011 01:22:55 +0100 |
| |
> On Fri, 2011-12-16 at 22:59 +0100, Marek Vasut wrote: > > static const unsigned char pci_irq_swizzle[2][PCI_MAX_DEVICES] = { > > > > {0, 0, 0, 0, 0, 0, 0, 27, 27, [9 ... PCI_MAX_DEVICES - 1] = 0 }, > > {0, 0, 0, 0, 0, 0, 0, 29, 29, [9 ... PCI_MAX_DEVICES - 1] = 0 }, > > > > }; > > True. > > Andy will probably figure it out. > He's the maintainer. > > Still, in this case all the 0's are unnecessary. > I'd probably write that code as: > > static const unsigned char pci_irq_swizzle[2][PCI_MAX_DEVICES] = { > { [7] = 27, [8] = 27 }, > { [7] = 29, [8] = 29 }, > };
I suspect this is some remnant of ancient code where the people writing it were not sure if the memory under this is all-zeroes. (or the section this lands in wasn't zeroed-out)
M
| |