Messages in this thread | | | Date | Wed, 14 Dec 2011 15:22:12 -0800 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH 3/4] EFI: Add support for variables longer than 1024 bytes |
| |
On 12/14/2011 03:06 PM, Mike Waychison wrote: > On Wed, Dec 14, 2011 at 3:00 PM, H. Peter Anvin <hpa@zytor.com> wrote: >> On 12/14/2011 02:57 PM, Mike Waychison wrote: >>> >>> Well,l we could *not* support returning all the data field for >>> datasize > 1024, and simply truncate the field. We are limited by >>> PAGE_SIZE by sysfs here anyway (so we don't really want to have a >>> variable size memcpy in efivar_show_raw). >>> >> >> That may be the biggest reason to avoid sysfs. As far as I know sysfs >> doesn't allow seq_file to be used. >> > > Completely agreed. I don't think a seq_file is warranted in this case > in particular, but the dummification of the interfaces in sysfs sure > makes it hard to do anything that isn't a "single value string". >
Well, seq_file is a good way to deal with arbitrary length data.
-hpa
| |