Messages in this thread | | | Date | Wed, 14 Dec 2011 23:15:53 +0100 | Subject | Re: [RFC PATCH v2 4/4] mmc: sdhci-esdhc-imx: using pinmux subsystem | From | Linus Walleij <> |
| |
On Wed, Dec 14, 2011 at 10:11 PM, Sascha Hauer <s.hauer@pengutronix.de> wrote: > On Thu, Dec 15, 2011 at 12:03:42AM +0800, Dong Aisheng wrote:
>> + pmx = pinmux_get(&pdev->dev, NULL); >> + if (IS_ERR(pmx)) { >> + err = PTR_ERR(pmx); >> + goto err_pmx_get; >> + } >> + err = pinmux_enable(pmx); >> + if (err) >> + goto err_pmx_enable; >> + imx_data->pmx = pmx; >> + > > Won't this break every i.MX except i.MX6?
Not this patch on its own, first the machines have to select PINCTRL select PINMUX_FOO
*Then* it will break :-D
So if you want to do this for i.MX you need something like selectable dummy pinmuxes, i.e. pinmux_get() to return something that just say "OK" to everything like the dummy regulators.
Shall I try to create something like that?
Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |