Messages in this thread Patch in this message | ![/](/images/icornerl.gif) | | From | Matthew Garrett <> | Subject | [PATCH 2/4] efi: Only create sysfs entries while booting or running | Date | Wed, 14 Dec 2011 16:06:29 -0500 |
| |
There's no point in creating sysfs entries while the machine's on its way down. Skip it in that case in order to avoid complexity.
Signed-off-by: Matthew Garrett <mjg@redhat.com> --- drivers/firmware/efivars.c | 17 ++++++++++++----- 1 files changed, 12 insertions(+), 5 deletions(-)
diff --git a/drivers/firmware/efivars.c b/drivers/firmware/efivars.c index b0a8117..eb07f13 100644 --- a/drivers/firmware/efivars.c +++ b/drivers/firmware/efivars.c @@ -552,11 +552,18 @@ static int efi_pstore_write(enum pstore_type_id type, u64 *id, if (found) efivar_unregister(found); - if (size) - ret = efivar_create_sysfs_entry(efivars, - utf16_strsize(efi_name, - DUMP_NAME_LEN * 2), - efi_name, &vendor); + if (size) { + switch (system_state) { + case SYSTEM_BOOTING: + case SYSTEM_RUNNING: + ret = efivar_create_sysfs_entry(efivars, + utf16_strsize(efi_name, + DUMP_NAME_LEN * 2), + efi_name, &vendor); + default: + break; + } + } *id = part; return ret; -- 1.7.7.1
| ![\](/images/icornerr.gif) |