lkml.org 
[lkml]   [2011]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] arch/tile: misplaced parens near likely
On 12/12/2011 5:34 PM, roel wrote:
> Parentheses were missing.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>

Thanks, I'll take this into the tile tree.

> ---
> arch/tile/lib/spinlock_32.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> This is what it should be, right?
>
> diff --git a/arch/tile/lib/spinlock_32.c b/arch/tile/lib/spinlock_32.c
> index cb0999f..b16ac49 100644
> --- a/arch/tile/lib/spinlock_32.c
> +++ b/arch/tile/lib/spinlock_32.c
> @@ -144,7 +144,7 @@ void arch_read_unlock(arch_rwlock_t *rwlock)
> for (;;) {
> __insn_mtspr(SPR_INTERRUPT_CRITICAL_SECTION, 1);
> val = __insn_tns((int *)&rwlock->lock);
> - if (likely(val & 1) == 0) {
> + if (likely((val & 1) == 0)) {
> rwlock->lock = val - (1 << _RD_COUNT_SHIFT);
> __insn_mtspr(SPR_INTERRUPT_CRITICAL_SECTION, 0);
> break;

--
Chris Metcalf, Tilera Corp.
http://www.tilera.com



\
 
 \ /
  Last update: 2011-12-14 17:39    [W:0.029 / U:1.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site