Messages in this thread | | | From | Chanho Park <> | Subject | RE: [PATCH v6] pinctrl: add a pin config interface | Date | Wed, 14 Dec 2011 16:04:22 +0900 |
| |
> ChangeLog v5->v6: > - Change to using a pin name as parameter for the > [get|set]_config() functions, as suggested by Stephen Warren. > This is more natural as names will be what a developer has > access to in written documentation etc.
I don't agree with it. Someone doesn't like to assign a pin name individually because a pin number is sufficient to represent each pin. We also provide a macro to define a anonymous pin descriptor.
/* Convenience macro to define a single named or anonymous pin descriptor */ #define PINCTRL_PIN(a, b) { .number = a, .name = b } #define PINCTRL_PIN_ANON(a) { .number = a }
If we use only the pin name for [get|set]_config(), we must assign the name of all pins. IMHO, we also provide pin numbers to control anonymous pins.
-- Best Regards, Chanho Park
| |