lkml.org 
[lkml]   [2011]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH V2] vmscan/trace: Add 'active' and 'file' info to trace_mm_vmscan_lru_isolate.
    On Sun, 11 Dec 2011 22:46:24 +0800
    Tao Ma <tm@tao.ma> wrote:

    > --- a/mm/vmscan.c
    > +++ b/mm/vmscan.c
    > @@ -1103,7 +1103,7 @@ int __isolate_lru_page(struct page *page, isolate_mode_t mode, int file)
    > static unsigned long isolate_lru_pages(unsigned long nr_to_scan,
    > struct list_head *src, struct list_head *dst,
    > unsigned long *scanned, int order, isolate_mode_t mode,
    > - int file)
    > + int active, int file)
    > {
    > unsigned long nr_taken = 0;
    > unsigned long nr_lumpy_taken = 0;
    > @@ -1221,7 +1221,7 @@ static unsigned long isolate_lru_pages(unsigned long nr_to_scan,
    > nr_to_scan, scan,
    > nr_taken,
    > nr_lumpy_taken, nr_lumpy_dirty, nr_lumpy_failed,
    > - mode);
    > + mode, active, file);
    > return nr_taken;
    > }
    >
    > @@ -1237,7 +1237,7 @@ static unsigned long isolate_pages_global(unsigned long nr,
    > if (file)
    > lru += LRU_FILE;
    > return isolate_lru_pages(nr, &z->lru[lru].list, dst, scanned, order,
    > - mode, file);
    > + mode, active, file);
    > }

    It would be nice to avoid adding permanent runtime overhead on behalf
    of tracing. It sounds like sending "mode" will satisfy this - please
    check that in the v2 patch.



    \
     
     \ /
      Last update: 2011-12-14 01:47    [W:5.991 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site